Repository navigation
Count recording and trace notes as notes in clean-stop - #333
Merged
Merged
Conversation
#331 added these notes beside audio's. clean-stop took them for a daemon left running, with nothing running, and --quit could not clear them. Measured with 4 notes left by real runs: clean before reading them as a daemon, and a fake socket beside them still fails the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #331, which added recording and trace notes beside audio's lost-capture note.
clean-stop.shskipped onlyaudio-*, so it took the new notes for a daemon left running. It reported "something is still running" with nothing running, and--quitcould not clear them. That is the failure 285 already fixed for audio.Measured
With 4 notes left by real runs, the check says
cleanand lists them as lost captures. A fake socket beside them still fails it, and with no notes at all it saysclean.